Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to overlays code #9

Open
squaremo opened this issue Jan 7, 2019 · 1 comment
Open

Add types to overlays code #9

squaremo opened this issue Jan 7, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@squaremo
Copy link
Member

squaremo commented Jan 7, 2019

Either add the types file, or rewrite in typescript.
@squaremo squaremo added the enhancement New feature or request label Jan 7, 2019
@squaremo
Copy link
Member Author

squaremo commented Jan 8, 2019

First target: use the generated classes when constructing resources, e.g., in generateConfigMap.
This probably means pointing the tests at dist/, or compiling into src/. If rewriting in typescript, the latter is probably better -- just have to make sure make test does the compilation step first, and the tests point at modules in dist/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@squaremo