Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShinKGS inside an iframe #248

Open
wabu opened this issue Dec 15, 2020 · 1 comment
Open

ShinKGS inside an iframe #248

wabu opened this issue Dec 15, 2020 · 1 comment

Comments

@wabu
Copy link

wabu commented Dec 15, 2020

I get a javascript exception (no client) when shinKGS is opened inside a iframe, for example when going to a goban inside this work-adventure map

Would be great if I could also log in and play a game of go inside the iframe.

@wabu
Copy link
Author

wabu commented Dec 21, 2020

Maybe it is enough to run it just change the cookie policy to include SameSite=None and Secure: "Set-Cookie: third_party_var=value; SameSite=None; Secue"

This has to be done for sites that are embeddible and need auth, for example youtube. As the secure is added, the cookie is encrypted via https, so it won't get into the wrong hands.

Thanks for considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant