You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two issues with the SRD code. See code in the file src/state_redistribution.jl in branch cgt3-thesis-edits-recovery for the necessary fixes.
The logic in the parts of the SRD code is flipped. This is not an issue for meshes where cut elements can be stabilized by merging with a single neighbor (this was true of all our previous cut meshes) but will cause issues when this is not the case.
The data layout needed for Trixi fluxes was not compatible with our original SRD code due to a type issue. The above code also provides a fix (see lines of code dealing with array_type). This is a breaking change for codes that previously used SRD.
The text was updated successfully, but these errors were encountered:
There are two issues with the SRD code. See code in the file
src/state_redistribution.jl
in branch cgt3-thesis-edits-recovery for the necessary fixes.The logic in the parts of the SRD code is flipped. This is not an issue for meshes where cut elements can be stabilized by merging with a single neighbor (this was true of all our previous cut meshes) but will cause issues when this is not the case.
The data layout needed for Trixi fluxes was not compatible with our original SRD code due to a type issue. The above code also provides a fix (see lines of code dealing with
array_type
). This is a breaking change for codes that previously used SRD.The text was updated successfully, but these errors were encountered: