Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartUpDG t8code todo list #38

Open
1 of 2 tasks
jlchan opened this issue Sep 20, 2022 · 4 comments
Open
1 of 2 tasks

StartUpDG t8code todo list #38

jlchan opened this issue Sep 20, 2022 · 4 comments

Comments

@jlchan
Copy link
Owner

jlchan commented Sep 20, 2022

@Davknapp @jmark from our Trixi discussion

  • Generalize connectivity in MeshData (remove mapP, mapB as fields, replace with a general "node connectivity" field to enable t8code). Note: this should be non-breaking, since we can simply overload getproperties to ensure md.mapP still returns the relevant array.
  • Add ability to create connectivities between different MeshData objects.

If there is anything else you can think of, please feel free to add those items.

@jmark
Copy link
Collaborator

jmark commented Oct 14, 2022

@jlchan Can you imagine a MeshData constructor which accepts a list of face connectivity (with orientation ;) and a list of physical points and Jacobians evaluated on quadrature points per element?

@jlchan
Copy link
Owner Author

jlchan commented Oct 14, 2022

Certainly. I don't need the orientation for my own constructor but I can certainly store it.

Are the physical points interpolation points or quadrature points? I would prefer interpolation points if possible (easier to enforce a watertight mesh).

@jmark
Copy link
Collaborator

jmark commented Oct 14, 2022

Sure, interpolation points will work.

Yeah, I think we have to pass the orientation to the user to take care of it so that the interpolated face values from each side correctly match according to the mesh.

@jlchan
Copy link
Owner Author

jlchan commented Oct 14, 2022

Sounds good. FYI, we account for orientation when computing the mapP array - any changes in orientation are accounted for in the ordering of the node maps, and these node maps are just computed based on node positions (if two nodes basically have the same coordinates, we map one to the other).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants