Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements and API changes for v0.11.x #8

Closed
9 of 10 tasks
jlchan opened this issue Jun 24, 2021 · 1 comment
Closed
9 of 10 tasks

Improvements and API changes for v0.11.x #8

jlchan opened this issue Jun 24, 2021 · 1 comment
Assignees
@jlchan

Comments

@jlchan
Copy link
Owner

jlchan commented Jun 24, 2021 •
edited
Loading

Todo list:

Leaving for v0.12.x

Breaking API changes:

  • have uniform_mesh output a tuple (VX, VY, VZ), have MeshData take that as an input
  • tag_boundary_faces: switch from foo(x,y), foo(x,y,z) to foo(x::NTuple{Dim, T}) where {Dim, T}).
  • clean up Triangulate example meshes: switch to kwargs for h
  • use dispatch for Triangulate example meshes, e.g., example_mesh(Scramjet(), h = ...)
@jlchan jlchan changed the title Improvements Improvements and API changes Jun 29, 2021
@jlchan jlchan changed the title Improvements and API changes Improvements and potential API changes Jun 30, 2021
@jlchan jlchan changed the title Improvements and potential API changes Improvements and API changes for v0.11.0 Jul 3, 2021
@jlchan jlchan self-assigned this Jul 20, 2021
@jlchan jlchan changed the title Improvements and API changes for v0.11.0 Improvements and API changes for v0.11.x Aug 3, 2021
@jlchan
Copy link
Owner Author

jlchan commented Jun 23, 2022

Closing since the remaining todos are new issues

@jlchan jlchan closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlchan jlchan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlchan