Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jansi's windows support #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use jansi's windows support #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,6 @@
<exclude>junit/**</exclude>
<exclude>org/junit/**</exclude>
<exclude>org/hamcrest/**</exclude>
<exclude>org/fusesource/hawtjni/runtime/Jni*</exclude>
<exclude>org/fusesource/hawtjni/runtime/*Flag*</exclude>
<exclude>org/fusesource/hawtjni/runtime/T32*</exclude>
<exclude>org/fusesource/hawtjni/runtime/NativeStats*</exclude>
</excludes>
</filter>
</filters>
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/jline/AnsiWindowsTerminal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ private static OutputStream wrapOutputStream(final OutputStream stream) {
}

private static boolean detectAnsiSupport() {
AnsiConsole.systemInstall();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is valid, detection of ANI support should not install ANSI support, which is what this change does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this should be part of the software using jline imho.


OutputStream out = AnsiConsole.wrapOutputStream(new ByteArrayOutputStream());
try {
out.close();
Expand Down