Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small fix about install, string, datetime, deprecated #60

Merged
merged 12 commits into from
Aug 16, 2024

Conversation

mckillo
Copy link
Contributor

@mckillo mckillo commented Aug 16, 2024

Update some commits, debugging some details that I'm going found in my migration to last version of your extension.
Attachment 4.0.2 (12 july24), Joomla 5.1.2, PHP 8.2.12, MariaDB: 10.4.32, Yootheme Pro: 4.4.5

Declare the component as the first element of the file list, so that this zip is the first to be installed. The component is the base of the installation, then modules and components.
For this reason, the order has been changed and the component line has been placed first.
Fix error ATTACH_PACKAGE_ATTACHMENTS_FOR_JOOMLA_40PLUS doesn't exist.
The version in the string is updated for Joomla 4.0+.
Now, the package name is right.
Update code with datetime when the article could have a null in publish_up and publish_down value.
@parapente
Copy link
Collaborator

Looks ok. Thank you @mckillo. If @JLTRY agrees we can merge it.

@JLTRY
Copy link
Collaborator

JLTRY commented Aug 16, 2024

@parapente i am in vacations.I let you the hand

@parapente parapente merged commit e73dfc0 into jmcameron:master Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants