You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When upgrading to v3.14.0 which merged 3dcba7d, I get the following error
(node:465857) UnhandledPromiseRejectionWarning: TypeError: this.metadataScanner.getAllMethodNames is not a function at DiscoveryService.classMethodsWithMetaAtKey (/home/dusan/Projects/web-api/node_modules/@golevelup/nestjs-discovery/src/discovery.service.ts:171:33)
From @golevelup/nestjs-discovery this is expected because of their peer deps:
while nest-commander@3 is supposed to support nestjs v8:
So I guess the only fix to this is doing some patching here (for nestjs v8 users only) because there is no version of @golevelup/nestjs-discovery that supports both nestjs v8 and v10 at same time, I just checked. Or maybe @jmcdo29 could just drop @golevelup/nestjs-discovery, idk
Is there an existing issue that is already proposing this?
Potential Commit/PR that introduced the regression
3dcba7d
Versions
3.13.0 -> 3.14.0
Describe the regression
When upgrading to v3.14.0 which merged 3dcba7d, I get the following error
which is caused by fixing use of deprecated method
scanFromPrototype
golevelup/nestjs@92bf751Minimum reproduction code
Expected behavior
Nest-commander should continue working with older nest versions.
Minor version upgrade is not expected to introduce breaking changes.
Other
No response
The text was updated successfully, but these errors were encountered: