Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander broken with nestjs v8 #1154

Open
1 task done
uvera opened this issue Jul 18, 2024 · 1 comment
Open
1 task done

Commander broken with nestjs v8 #1154

uvera opened this issue Jul 18, 2024 · 1 comment

Comments

@uvera
Copy link

uvera commented Jul 18, 2024

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Potential Commit/PR that introduced the regression

3dcba7d

Versions

3.13.0 -> 3.14.0

Describe the regression

When upgrading to v3.14.0 which merged 3dcba7d, I get the following error

(node:465857) UnhandledPromiseRejectionWarning: TypeError: this.metadataScanner.getAllMethodNames is not a function
    at DiscoveryService.classMethodsWithMetaAtKey (/home/dusan/Projects/web-api/node_modules/@golevelup/nestjs-discovery/src/discovery.service.ts:171:33)

which is caused by fixing use of deprecated method scanFromPrototype golevelup/nestjs@92bf751

Minimum reproduction code

Expected behavior

Nest-commander should continue working with older nest versions.
Minor version upgrade is not expected to introduce breaking changes.

Other

No response

@micalevisk
Copy link
Contributor

micalevisk commented Oct 12, 2024

yeah, indeed

From @golevelup/nestjs-discovery this is expected because of their peer deps:

image

while nest-commander@3 is supposed to support nestjs v8:

image

So I guess the only fix to this is doing some patching here (for nestjs v8 users only) because there is no version of @golevelup/nestjs-discovery that supports both nestjs v8 and v10 at same time, I just checked. Or maybe @jmcdo29 could just drop @golevelup/nestjs-discovery, idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants