Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line endings changed on copyright application. #6

Open
ekitrak opened this issue Jan 31, 2018 · 2 comments
Open

Line endings changed on copyright application. #6

ekitrak opened this issue Jan 31, 2018 · 2 comments

Comments

@ekitrak
Copy link

ekitrak commented Jan 31, 2018

Applying a copyright changes all line endings to CRLF on Windows.
We use LF line endings in our codebase, so after each application I have to go in and change line endings back to LF.

@jmini
Copy link
Owner

jmini commented Feb 1, 2018

Thank you for reporting this your issue. I will try to have a look at it.

I did not wrote the plugin myself (it is a fork from a project hosted on sourceforge that was no longer available).

Will you by any chance make a contribution for this? If yes I will be happy to review, test and merge it.

From what I know from the eclipse inside, there is a utility method that should be called in order to fix the lines endings (according to the settings) after any modification of a file.

@jmini
Copy link
Owner

jmini commented Feb 19, 2018

In Eclipse IDE:

The pref key is line.separator in the bundle org.eclipse.core.runtime.

Corresponding Java constant: org.eclipse.core.runtime.Platform.PREF_LINE_SEPARATOR


In the Eclipse-Copyright-Generator plugin, the code handling the copyright modification is located in the com.wdev91.eclipse.copyright.model.CopyrightManager.CopyrightJob class. I guess it should be rewritten to use more features of the Eclipse Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants