Eglot stopped returning completions for dart-mode #1405
-
|
I have a small issue that I would greatly appreciate help with. I have been using Corfu, Eglot, and dart-mode to develop for about 6 weeks, and everything worked fine. However, last week while writing code, Corfu stopped showing autocompletion for dart/flutter regardless of what I tried. Here is my config relating to Flutter Corfu and Eglot. Corfu still shows auto-completion for all the other languages I develop in, so this points to me believing the issue might be with eglot interacting with the dart language server. Here is my config: (setq tab-always-indent 'complete)
(when (maybe-require-package 'orderless)
(with-eval-after-load 'vertico
(require 'orderless)
(setq completion-styles '(orderless basic))))
(setq completion-category-defaults nil
completion-category-overrides nil)
(setq completion-cycle-threshold 4)
(when (maybe-require-package 'corfu)
(setq-default corfu-auto t)
(with-eval-after-load 'eshell
(add-hook 'eshell-mode-hook (lambda () (setq-local corfu-auto nil))))
(setq-default corfu-quit-no-match 'separator)
(add-hook 'after-init-hook 'global-corfu-mode)
(with-eval-after-load 'corfu
(corfu-popupinfo-mode))
;; Make Corfu also work in terminals, without disturbing usual behaviour in GUI
(when (maybe-require-package 'corfu-terminal)
(with-eval-after-load 'corfu
(corfu-terminal-mode)))
)
(use-package svg-lib)
(use-package kind-icon
:ensure t
:after corfu
:custom
(kind-icon-blend-background t)
(kind-icon-default-face 'corfu-default) ; only needed with blend-background
:config
(add-to-list 'corfu-margin-formatters #'kind-icon-margin-formatter))
(when (maybe-require-package 'eglot)
(maybe-require-package 'consult-eglot))
(with-eval-after-load 'eglot
(add-to-list 'eglot-server-programs '((web-mode) . ("typescript-language-server")))
(add-to-list 'eglot-server-programs '((rust-mode rust-ts-mode) . ("rust-analyzer"))))
(dolist (mode '(bash-ts-mode-hook
c-mode-hook
css-mode-hook
css-ts-mode-hook
closure-ts-mode-hook
dart-mode-hook
dockerfile-mode-hook
js-mode-hook
js-ts-mode-hook
less-css-mode-hook
php-mode-hook
python-mode-hook
python-ts-mode-hook
prisma-ts-mode-hook
ruby-mode-hook
ruby-ts-mode-hook
rust-mode-hook
go-mode-hook
go-ts-mode-hook
rust-ts-mode-hook
sass-mode-hook
scss-mode-hook
terraform-mode-hook
typescript-mode-hook
tsx-ts-mode-hook
ts-mode-hook
yaml-mode-hook
c++-mode-hook))
(add-hook mode 'eglot-ensure))
;; Assuming usage with dart-mode
(use-package dart-mode
;; Optional
:hook (dart-mode . flutter-test-mode))
(use-package flutter
:after dart-mode
:bind (:map dart-mode-map
("C-M-x" . #'flutter-run-or-hot-reload))
:custom
(flutter-sdk-path "/opt/homebrew/bin/flutter"))
(reformatter-define dart-format
:program "dart"
:args '("format"))
(add-to-list 'eglot-server-programs '(dart-mode . ("dart" "language-server")))
(with-eval-after-load "dart-mode"
(define-key dart-mode-map (kbd "C-c C-o") 'dart-format-buffer))
(add-hook 'dart-mode-hook (lambda () (add-hook 'after-save-hook 'dart-format-buffer nil t)))
(add-hook 'flutter-test-mode-hook (lambda () (add-hook 'after-save-hook #'flutter-run-or-hot-reload nil t)))
(add-hook 'flutter-mode-hook (lambda () (add-hook 'after-save-hook #'flutter-run-or-hot-reload nil t)))Contents of Dart file:import 'package:flutter/material.dart';
import 'package:sqflite/sqflite.dart';
import 'state/app_state.dart';
import 'widgets/map.dart';
import 'package:provider/provider.dart';
import 'widgets/home_app_bar.dart';
import 'package:get/get.dart';
import 'package:flutter_background_geolocation/flutter_background_geolocation.dart'
as bg;
import 'dart:io';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
// This widget is the root of Loadaman.
@override
Widget build(BuildContext context) {
return GetMaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.black),
useMaterial3: true,
),
home: const MyHomePage(title: 'Loadaman'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
// Controls the bottom navigator
int _selectedIndex = 0;
void _onItemTapped(int index) {
setState(() {
_selectedIndex = index;
});
}
static const List<Widget> _pages = <Widget>[
MapWidget(),
Center(
child: Text('Services'),
),
Center(
child: Text('Activity'),
),
Center(
child: Text('Account'),
),
];
@override
void initState() {
super.initState();
var db = openDatabase('loadaman', version: 1, onOpen: (Database db) async {
print('Database version: ${await db.getVersion()}');
}, onCreate: (Database db, int version) async {
await db.execute(
'CREATE TABLE location(id INTEGER PRIMARY KEY, lattitude REAL, longitude REAL)');
});
}
@override
Widget build(BuildContext context) {
final ThemeData theme = Theme.of(context);
return ChangeNotifierProvider<AppState>(
create: (context) => AppState(),
child: SafeArea(
child: Scaffold(
appBar: HomeAppBar(
title: widget.title,
),
body: _pages.elementAt(_selectedIndex),
bottomNavigationBar: BottomNavigationBar(
items: <BottomNavigationBarItem>[
BottomNavigationBarItem(
backgroundColor: theme.iconTheme.color,
icon: const Icon(Icons.home),
label: 'Home',
),
BottomNavigationBarItem(
backgroundColor: theme.iconTheme.color,
icon: const Icon(Icons.apps),
label: 'Services',
),
BottomNavigationBarItem(
backgroundColor: theme.iconTheme.color,
icon: const Icon(Icons.newspaper),
label: 'Activities',
),
BottomNavigationBarItem(
backgroundColor: theme.iconTheme.color,
icon: const Icon(Icons.person),
label: 'Account',
),
],
backgroundColor: theme.iconTheme.color,
selectedItemColor: Colors.amberAccent,
selectedIconTheme: const IconThemeData(color: Colors.amberAccent),
currentIndex: _selectedIndex,
onTap: _onItemTapped,
enableFeedback: true,
),
),
),
);
}
}
Here's an error log I got once when trying to debug this issue:Debugger entered--Lisp error: (jsonrpc-error "request id=64 failed:" (jsonrpc-error-message . "Timed out"))
signal(jsonrpc-error ("request id=64 failed:" (jsonrpc-error-message . "Timed out")))
#<subr jsonrpc-request>(#<eglot-lsp-server eglot-lsp-server-4d0d2768> :textDocument/completion (:textDocument (:uri "file:///Users/randyburrell/Projects/Work/Randy/Loa...") :position (:line 10 :character 4) :context (:triggerKind 1)) :deferred :textDocument/completion :cancel-on-input t)
apply(#<subr jsonrpc-request> (#<eglot-lsp-server eglot-lsp-server-4d0d2768> :textDocument/completion (:textDocument (:uri "file:///Users/randyburrell/Projects/Work/Randy/Loa...") :position (:line 10 :character 4) :context (:triggerKind 1)) :deferred :textDocument/completion :cancel-on-input t))
jsonrpc-request(#<eglot-lsp-server eglot-lsp-server-4d0d2768> :textDocument/completion (:textDocument (:uri "file:///Users/randyburrell/Projects/Work/Randy/Loa...") :position (:line 10 :character 4) :context (:triggerKind 1)) :deferred :textDocument/completion :cancel-on-input t)
#f(compiled-function () #<bytecode 0x1d97b3477f652e0e>)()
#f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>)("" nil t)
completion-pcm--all-completions("" (prefix "i" any "m" any "p" any "o") #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil)
completion-substring--all-completions("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4 completion-flex--make-flex-pattern)
#<subr completion-flex-all-completions>("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4)
apply(#<subr completion-flex-all-completions> ("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4))
completion-flex-all-completions("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4)
#f(compiled-function (style) #<bytecode -0x18c96571742c93bf>)(flex)
completion--some(#f(compiled-function (style) #<bytecode -0x18c96571742c93bf>) (flex basic orderless))
completion--nth-completion(2 "impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4 (metadata (category . eglot) (display-sort-function . #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_151>)))
#<subr completion-all-completions>("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4 (metadata (category . eglot) (display-sort-function . #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_151>)))
apply(#<subr completion-all-completions> ("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4 (metadata (category . eglot) (display-sort-function . #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_151>))))
completion-all-completions("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4 (metadata (category . eglot) (display-sort-function . #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_151>)))
corfu--filter-completions("impo" #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil 4 (metadata (category . eglot) (display-sort-function . #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_151>)))
corfu--recompute("impo" 4 #f(compiled-function (probe pred action) #<bytecode 0xb16bffce9dc675a>) nil)
corfu--update(interruptible)
#f(compiled-function (&optional auto) #<bytecode 0x1d4c8c548ab2ea4c>)(auto)
apply(#f(compiled-function (&optional auto) #<bytecode 0x1d4c8c548ab2ea4c>) auto)
#f(compiled-function (&rest args) #<bytecode -0x11808fa36a21efe5>)(auto)
apply(#f(compiled-function (&rest args) #<bytecode -0x11808fa36a21efe5>) auto)
corfu--exhibit(auto)
corfu--auto-complete-deferred((#<window 2073 on main.dart> #<buffer main.dart> 1734 363))
apply(corfu--auto-complete-deferred (#<window 2073 on main.dart> #<buffer main.dart> 1734 363))
timer-event-handler([t 26199 11817 483055 nil corfu--auto-complete-deferred ((#<window 2073 on main.dart> #<buffer main.dart> 1734 363)) nil 0 nil])
sit-for(3)
flyspell-check-word-p()
flyspell-post-command-hook()Eglot Events Buffer PrinntsCould you point me in the right direction to solve this issue? |
Beta Was this translation helpful? Give feedback.
Answered by
zikajk
Jul 27, 2024
Replies: 2 comments 22 replies
-
|
Could you try following the steps lined out here? Specifically, could you provide a recipe from |
Beta Was this translation helpful? Give feedback.
14 replies
-
|
Note that I and possibly other Eglot maintainers have no idea of dart, flutter, nix, or the particular brand of corn flakes you are using. This is likely a server issue, but if you really really want to submit a bug recipe, it can't be just that description, you really have to follow the steps in https://joaotavora.github.io/eglot/#Reporting-bugs-1, especially step 7. There can be no ambiguity as to what is installed or how, what keys are pressed when, etc. Assume the Eglot maintainers are all idiots: in the end a very illiterate user who's never heard of Emacs or should be able to produce exactly the same results you did. |
Beta Was this translation helpful? Give feedback.
-
|
@manuel-uberti Thanks for your help in pointing me in the right direction, I appreciated it. @joaotavora this was uncalled for:
I will:
I think this is a compatibility issue because Dart's language server works well with VS Code but it is not my main editor. It's not just:
Thanks. However, this is not necessary anymore:
The taste that this issue has left in my mouth has helped me with the decision to understand Emacs core for myself so that I do not need to ask package maintainers for help because the responses can be quite challenging sometimes. I thank you for your contributions and work. |
Beta Was this translation helpful? Give feedback.
-
I'm sorry man. I just wanted to highlight that there's a very complex fauna of servers, server versions, OS, etc. you wrote earlier " I hope this is addressed soon because I become very unproductive" This is uncalled for IMO, it posits that your problems are also the problems of unpaid volunteers, and they're not. AFAIK I'm one of the few people considering installing user's servers on my hardware, trying to mimic their setup, and spending time debugging their problems which are most often server problems due to things omitted from the recipes (like this server downgrade/upgrade you have performed). I mean, if compensate me directly for my time, I'll install about anything on my machine, and go on any wild goose chase you want. If you don't , I transfer the cost of creating an error recipe to you.
This shows you have grasped the challenge, but probably not the benefit of crafting high-quality error recipes.
It's fine to think and conjecture things. But we don't know that, and we won't know that until we have scientifically reproducible experiment. |
Beta Was this translation helpful? Give feedback.
-
@joaotavora please note that I meant no disrespect and held none of the maintainers obligated to fix anything for me. I just needed to be pointed in the right direction to fix it myself. As a dev myself, I am very appreciative of the work you and others put into these open-source projects. This helps people to get access to quality software and drive innovations forward. Hoping that it's fixed soon was just that. Just a hope, nothing more, nothing less. Just hoping that someone might shine their grace on me and take up the challenge or ask me some questions so that they can point me in the right direction to fix it myself. I wouldn't expect you to go on any sort of goose chase. Trust me, I know how valuable time is. I also understand your dilemma, I was not clear with my recipe. However, I didn't understand what a recipe was, so I should have probably asked what the recipe was to begin with. I'm just happy I figured out what the problem was. Great work with Eglot btw. I would love to support the project and others like it in my free time. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the great discussion here - I was also unable to get code completion to work with the Flutter SDK 3.22.3 but downgrading to 3.19.6 seemed to fix the issue |
Beta Was this translation helpful? Give feedback.
-
|
@joaotavora I found the issue: Based on the:
I was able to solve it by this quick change (I haven't experimented with different time values). But I guess it is not the best solution. Can you suggest the optional one? |
Beta Was this translation helpful? Give feedback.
8 replies
-
If I understood it won't be released. Or do you refer something different than the link i attached? And I think your suggested solution will work perfectly, i will try it tommorow. |
Beta Was this translation helpful? Give feedback.
-
Like, ever? |
Beta Was this translation helpful? Give feedback.
-
I don't know. I am just afraid that most Dart developers use VSCode nowadays and Emacs users aren't "significant" enough 😄. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, that's a trend. But the developer has made it clear that it will be fixe, just not in this one release. |
Beta Was this translation helpful? Give feedback.
-
|
@joaotavora Well, that's fine. Your idea works well anyway, so I would recommend it to others instead of downgrading flutter. |
Beta Was this translation helpful? Give feedback.
Answer selected by
joaotavora
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@joaotavora I found the issue:
dart-lang/sdk#56311
Based on the:
I was able to solve it by this quick change (I haven't experimented with different time values).