Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print in getLogins #2

Open
romankh opened this issue Jan 31, 2017 · 0 comments
Open

print in getLogins #2

romankh opened this issue Jan 31, 2017 · 0 comments

Comments

@romankh
Copy link
Contributor

romankh commented Jan 31, 2017

Is it intended that function getLogins always prints the result of the request in line 52 of protocol.py ?

output = requestor(key, input_data, id_, iv=iv)
print output

If yes, wouldn't it be better to have it being configurable with a parameter ?
romankh added a commit to romankh/python-keepasshttp that referenced this issue Jan 31, 2017
@romankh
jobevers#2: Adds conditional printing in method getLogins
39712a8
jobevers added a commit that referenced this issue Feb 13, 2018
@jobevers
Merge pull request #5 from romankh/2-print-getLogin
319501a 
#2: Adds conditional printing in method getLogins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romankh