Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank page with a js bug #253

Open
meyer59 opened this issue Sep 25, 2022 · 1 comment
Open

blank page with a js bug #253

meyer59 opened this issue Sep 25, 2022 · 1 comment

Comments

@meyer59
Copy link

meyer59 commented Sep 25, 2022

Describe the bug
A clear and concise description of what the bug is.
Unable to show the translation, the page show up for a few second and then everything disapear. A js bug appear in the console.

To Reproduce
Steps to reproduce the behavior:
update to the latest version
F5 the page.
The page show up for 1-2 sec and then blank (screenshot bellow)
Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image

Desktop (please complete the following information):

  • OS: WIN10
  • Browser chrome
  • Version 105
@lk77
Copy link

lk77 commented Sep 28, 2022

After debugging app.js,
it seems this translation from cloudinary is causing the issue :

'title_uploading_with_counter' => 'Uploading {{num}} Assets',

https://cloudinary.com/documentation/upload_widget#localization

it's not escaped by the frontend and it's executed as js, and it does not find a num variable

It also means it's possible to inject js code with translations when doing something like {{alert('test')}}

Screenshot from 2022-09-28 12-14-02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants