This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
fix(docs): gradle compile config depreciation #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR facebook/react-native#20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations `implementation` and `api` which make `compile` obsolete. PR facebook/react-native#20853 covered the `link` command. Using `compile` will result in a warning message during app build and `compile` will be eventually removed by Gradle.
|
@joeferraro Could you merge this PR ? 🙏 Note: Tell me if you need a maintainer. |
|
I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR facebook/react-native#20767 bumped the version of the Android
Gradle Plugin to v3 which uses the newer Gradle dependency
configurations
implementationandapiwhich makecompileobsolete.
PR facebook/react-native#20853 covered the
linkcommand.Using
compilewill result in a warning message during app build andcompilewill be eventually removed by Gradle.