New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetPrediction doesn't reset analyzer state after each use #4

Open

KitchenPC opened this issue Aug 28, 2012 · 1 comment

Assignees

KitchenPC commented Aug 28, 2012

Calling GetPrediction() multiple times on the same Analyzer instance will get different results, as "I" and "invI" are not reset.

I would suggest adding:

public float GetPrediction(Entry item, Index first, Index second)
{
invI = I = 0; // <--- Reset I and invI
...
}

ghost assigned joelmartinez

Owner

joelmartinez commented Aug 29, 2012

Good point, the analyzer should definitely be reusable ... I'll work on this soon, unless you want to send me a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment