Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo/doc left-hand side-bar navigation has too many buttons #64

Open
jrwarwick opened this issue Dec 3, 2020 · 3 comments
Open

Demo/doc left-hand side-bar navigation has too many buttons #64

jrwarwick opened this issue Dec 3, 2020 · 3 comments
Labels
good first issue Issue is straightforward and simple. Github platform will automatically recommend this to explorers.

Comments

@jrwarwick
Copy link
Collaborator

With the adding of sections, the left-hand side bar now overflows on the bottom on not-too modestly sized screens (a laptop, in my case). Even though it reduces the flavor, I think we need to lose the "TOP" button and the "SRC" button. Or possibly if someone is feeling ambitious, move them to the bottom horizontal footer frame bar.

@jrwarwick jrwarwick added the good first issue Issue is straightforward and simple. Github platform will automatically recommend this to explorers. label Dec 3, 2020
@dthv
Copy link
Contributor

dthv commented Dec 3, 2020

Moving them to the horizontal bars entails modifying the element's height. This is something @xenziffen managed to do in their fork (edit: cf. #53). Their solution should be integrated (and/or improved).

On the issue: For the future, it would be preferably if one finds a solution for overlong elements, esp. bars. This could entail "half-height" buttons (not exactly half, I'm afraid) that would also fit in the horizontal bars, also in vertical bars.

After master has been renamed into main (edit: cf. #63), I will open a PR to remove TOP/SRC for a quick fix.

@xenziffen
Copy link

xenziffen commented Dec 4, 2020 via email

@jrwarwick
Copy link
Collaborator Author

@xenziffen I have discovered that you will not be credited as a "contributor" by GitHub systems unless you file a PR. Indeed, I believe there are a few of your commits in there already (I must have branched off of your fork or something), which brought in your work on color specificity (three commits starting with aeec489 from around the end of February), but that did not result your addition to the Contributors list.

If that doesn't matter to you, we'll certainly dig further into your work. Or perhaps you could find the simplest of your changes and create a simple, small PR that can be expedited, and that can stand for all of your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue is straightforward and simple. Github platform will automatically recommend this to explorers.
Projects
None yet
Development

No branches or pull requests

3 participants