Updating scrutinizer to take it easy on big model collections in the …

…root
johannesx75 · Feb 8, 2014 · b3705b2 · b3705b2
1 parent c89dc45
commit b3705b2
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 13 deletions.
diff --git a/.scrutinizer.yml b/.scrutinizer.yml
@@ -9,4 +9,4 @@ before_commands:
 
 filter:
     paths: [lib/*]
-    excluded_paths: [bin/*, examples/*, vendor/*]
+    excluded_paths: [ bin/*, examples/*, vendor/*, lib/Tmdb/Model/*.php ]
diff --git a/lib/Tmdb/Model/Collection/Images.php b/lib/Tmdb/Model/Collection/Images.php
@@ -163,4 +163,27 @@ function($key, $value) use ($height) {
             }
         );
     }
+
+    /**
+     * Return a single image that is rated highest
+     *
+     * @return ImageFilter|null
+     */
+    public function filterBestVotedImage()
+    {
+        $currentImage = null;
+        $voteAverage  = 0;
+
+        /**
+         * @var $image Image
+         */
+        foreach($this->data as $image) {
+            if ($image->getVoteAverage() > $voteAverage) {
+                $voteAverage  = $image->getVoteAverage();
+                $currentImage = $image;
+            }
+        }
+
+        return $currentImage;
+    }
 }
diff --git a/test/Tmdb/Tests/Factory/ImageFactoryTest.php b/test/Tmdb/Tests/Factory/ImageFactoryTest.php
@@ -186,18 +186,6 @@ public function shouldFilterMaxWidth()
         }
     }
 
-    /**
-     * @test
-     */
-    public function shouldFilterBestImage()
-    {
-        $this->setUp();
-
-        $image = $this->images->filterBestVotedImage();
-
-        $this->assertInstanceOf('Tmdb\Model\Image', $image);
-    }
-
     protected function getFactoryClass()
     {
         return 'Tmdb\Factory\ImageFactory';