Reviewing

johannesx75 · Jan 30, 2014 · c6e4bfb · c6e4bfb
1 parent 4d73a02
commit c6e4bfb
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 26 deletions.
diff --git a/lib/Tmdb/Factory/ImageFactory.php b/lib/Tmdb/Factory/ImageFactory.php
@@ -54,29 +54,6 @@ public function createFromPath($path, $key)
         );
     }
 
-    /**
-     * Return possible image type keys
-     *
-     * @return string[]
-     */
-    public function getPossibleKeys()
-    {
-        return array(
-            'poster',
-            'posters',
-            'poster_path',
-            'backdrop',
-            'backdrops',
-            'backdrop_path',
-            'profile',
-            'profiles',
-            'profile_path',
-            'logo',
-            'logos',
-            'logo_path',
-        );
-    }
-
     /**
      * @param string|null $key
      * @return Image|Image\BackdropImage|Image\LogoImage|Image\PosterImage|Image\ProfileImage|Image\StillImage

diff --git a/lib/Tmdb/Repository/CompanyRepository.php b/lib/Tmdb/Repository/CompanyRepository.php
@@ -80,7 +80,7 @@ public function getMovieFactory()
      * @param $data
      * @return Movie[]
      */
-    private function createMovieCollection($data){
+    public function createMovieCollection($data){
         $collection = new GenericCollection();
 
         if (array_key_exists('results', $data)) {

diff --git a/lib/Tmdb/Repository/GenreRepository.php b/lib/Tmdb/Repository/GenreRepository.php
@@ -71,4 +71,12 @@ public function getApi()
     {
         return $this->getClient()->getGenresApi();
     }
-}
+
+    /**
+     * @return GenreFactory
+     */
+    public function getFactory()
+    {
+        return new GenreFactory();
+    }
+}
diff --git a/test/Tmdb/Tests/Api/TestCase.php b/test/Tmdb/Tests/Api/TestCase.php
@@ -33,7 +33,7 @@ protected function getApiMock(array $methods = array())
         return $this->getMockBuilder($this->getApiClass())
             ->setMethods(
                 array_merge(
-                    array('get', 'post', 'postRaw', 'patch', 'delete', 'put'),
+                    array('get', 'post', 'postRaw', 'head', 'patch', 'delete', 'put'),
                     $methods
                 )
             )

diff --git a/test/Tmdb/Tests/Repository/CompanyRepositoryTest.php b/test/Tmdb/Tests/Repository/CompanyRepositoryTest.php
@@ -37,6 +37,25 @@ public function shouldGetMovies()
     }
 
 
+    /**
+     * @test
+     */
+    public function callingGetMoviesWithFakeRequestWillReturnMovieCollection()
+    {
+        $repository = $this->getRepositoryWithMockedHttpClient();
+
+        $collection = $repository->createMovieCollection(
+            array('results' => array(
+                array('id' => 1),
+                array('id' => 2)
+            )
+            ));
+
+        foreach($collection as $movie) {
+            $this->assertInstanceOf('Tmdb\Model\Movie', $movie);
+        }
+    }
+
     protected function getApiClass()
     {
         return 'Tmdb\Api\Company';