Merging with Signal and Whatsapp imports #27
Comments
ghost
changed the title
|
Merging is on the long time planning, but currently I'm recovering from Covid19 and I honestly have no energy to take on this task right now. |
|
Omg now I feel like a jerk. |
|
If you want help, hit me up. My idea was mainly to copy the Whatsapp Import feature of @jukefoxer s fork into this, so it all can be merged into the main app. |
|
Hi Johan and Robert,
it would be great if my fork would be merged into Johan's fork and I would
welcome your contribution.
Yes, I had to abandon the project because I'm currently pretty overworked
with the upcoming product launch of my startup.
If you decide to do the merge, feel free to contact me with any questions (
***@***.***).
@johan: I'm sorry to hear about your Covid-infection and wish you a good
recovery.
Best,
Sam
Am So., 18. Apr. 2021 um 19:09 Uhr schrieb Robert S. <
***@***.***>:
… If you want help, hit me up.
My idea was mainly to copy the Whatsapp Import feature of @jukefoxer
<https://github.com/jukefoxer> s fork into this, so it all can be merged
into the main app.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHHDWBQYA6Y6IYGJO5MUPVDTJMG25ANCNFSM43D2OOQQ>
.
|
|
Hey Sam, thats great to hear! (Didn't actually expect this to work) Could you maybe point us to the place in your fork where you changed / inserted the "import Whatsapp msgstore.db" part? That would make things far easier. Ps: Your email is censored out, was that intentional? |
|
The 2 main files that do the import are: (contains the main entry point) and The strings that I added are in the file: https://github.com/jukefoxer/Signal-Android/blob/master/app/src/main/res/values/strings1.xml I also added an import dialog which is in (code and xml) https://github.com/jukefoxer/Signal-Android/blob/master/app/src/main/java/org/thoughtcrime/securesms/ImportWhatsappDialog.java The main entry point is the method: public static void importWhatsappFromSd(Context context, ProgressDialog progressDialog, boolean importGroups, boolean avoidDuplicates, boolean importMedia, int numDaysToImport) in the WhatsappBackupImporter.java file. ... Seems like there is no way I can let you know my email address that is non-public... |
|
Hey Sam, thanks a lot for that! @johanw666 do you think you can integrate those parts? (obviously after you recovered) |
|
The explanation of jukefoxer is helpful, I know what to do. I've already bought a 2nd device and put Android 11 on it, required for the manage storage stuff but rooting it causes problems (bootloops, unable to unlock the device, TWRP does not store its settings) so I'll have to wait until that is fixed. |
|
Hi Johan, |
Unfortunately my laptop is not going to handle that. It has the maximum amount of memory that it can handle (12GB) and a clean compile from Signal takes over 10 minutes (when no new libraries have to be downloaded). |
|
Hey @johanw666 , Kind regards Also adding a reference here: YuvrajRaghuvanshiS/WhatsApp-Key-Database-Extractor#64 (comment) |
|
Hey guys, |
That's great! Thanks for letting us know. |
|
Unfortunately I don't have access to my development PC for the next week. But I can send you the version that is installed on my phone. It's a self-signed PlayProdRelease build for arm64-v8a of version 5.23.1.0-JW https://drive.google.com/file/d/1jDB6SdYupE2ClUXZlYfCCxMPW8VeUOYF/view?usp=sharing |
|
I finally found the time to merge this in my build and released in 5.23.6.1-JW. When I tested this I noticed 2 things: it crashed on my WA database when I selected "Import group chats", and when importing has reached the last record it just stops, I had to force-close Signal and then the new data was visible in Signal. Should I hard-close Signal from code when it is finished reading all WA data? |
|
I mean if it is a necessity, yes of course. Maybe try to do it with a little informational prompt or message tho. |
|
I didn't get the behavior at the end, the process just ends and I can click on the back key to get back to the chats overview. But I didn't import group chats... I'll try that in the next couple of days |
I might have missed something in the merge.
The groups import just crashed. I'll try again and see what the error was. Edit: I didn't create a same-named group in Signal first. But it shouldn't crash on that. |
|
@jukefoxer @roberts01 now that WhatsApp has also introduced message reactions, can anyone please check if it is easy to update the WA import code with this? I also got this question about the import when the senders are not in yur phone book: #49 , would that be difficult to fix? |
|
I'm unable to help directly, sorry. I don't have access to Whatsapp
anymore. If it helps, my approach to import specific Whatsapp features was
something like this:
- Set up an Android emulator, install Whatsapp and connect it to my
phone number
- Extract the Whatsapp DB
- Send/Receive 2-3 different messages using the feature I wanted to
import
- Extract the Whatsapp DB again
- Inspect the DB to see what changed. The semantics of WA tables and
columns usually becomes clear, because one knows what should have been
inserted.
- Search the Signal source code to find out how this feature is handled
in Signal
- Add an import method to the general import process
Am Mi., 11. Mai 2022 um 11:46 Uhr schrieb johanw666 <
***@***.***>:
… @jukefoxer <https://github.com/jukefoxer> @roberts01
<https://github.com/roberts01> now that WhatsApp has also introduced
message reactions, can anyone please check if it is easy to update the WA
import code with this? I also got this question about the import: #49
<#49> , would that be
difficult to fix?
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHHDWBWKF42PQOTMYM5ITW3VJN6WNANCNFSM43D2OOQQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Getting unencrypted WA databases is not a problem, all my Android devices are rooted so access to these is trivial. |
Hello @johanw666 ,
thank you very much for this fork.
In conjunction with @jukefoxer s fork of it, this is currently the only possibility of importing Whatsapp Chats to Signal.
To improve the transition process to Signal from other apps overall, I wanted to ask whether you are strategically considering to merge this into the main Signal app.
Furthermore, as @jukefoxer doesn't seem to be around anymore (and with no possibility of contacting them), I'd kindly ask you if you could try to add his "Whatsapp database import function" into your fork.
Regards
Robert S.
The text was updated successfully, but these errors were encountered: