Skip to content

Commit

Permalink
Remove unused lint disables
Browse files Browse the repository at this point in the history
  • Loading branch information
john-kurkowski committed Oct 24, 2020
1 parent 0357f97 commit df65b48
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 14 deletions.
4 changes: 0 additions & 4 deletions conftest.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
'''py.test standard config file.'''

# pylint: disable=invalid-name

collect_ignore = ('setup.py',)

# pylint: enable=invalid-name
2 changes: 0 additions & 2 deletions tests/custom_suffix_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
)
EXTRA_SUFFIXES = ['foo1', 'bar1', 'baz1']

# pylint: disable=invalid-name
extract_using_fake_suffix_list = tldextract.TLDExtract(
cache_dir=tempfile.mkdtemp(),
suffix_list_urls=[FAKE_SUFFIX_LIST_URL]
Expand All @@ -25,7 +24,6 @@
suffix_list_urls=[FAKE_SUFFIX_LIST_URL],
extra_suffixes=EXTRA_SUFFIXES
)
# pylint: enable=invalid-name


def test_private_extraction():
Expand Down
8 changes: 3 additions & 5 deletions tests/main_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from tldextract.tldextract import ExtractResult


# pylint: disable=invalid-name
extract = tldextract.TLDExtract(cache_dir=tempfile.mkdtemp())
extract_no_cache = tldextract.TLDExtract(cache_dir=False)
extract_using_real_local_suffix_list = tldextract.TLDExtract(cache_dir=tempfile.mkdtemp())
Expand All @@ -20,7 +19,6 @@
cache_dir=None,
suffix_list_urls=None
)
# pylint: enable=invalid-name


def assert_extract( # pylint: disable=missing-docstring
Expand Down Expand Up @@ -236,11 +234,11 @@ def test_result_as_dict():
assert result._asdict() == expected_dict


@responses.activate # pylint: disable=no-member
@responses.activate
def test_cache_timeouts(tmpdir):
server = 'http://some-server.com'
responses.add( # pylint: disable=no-member
responses.GET, # pylint: disable=no-member
responses.add(
responses.GET,
server,
status=408
)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_parallel.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ def _run_extractor(cache_dir):
@responses.activate
def test_cache_cleared_by_other_process(tmpdir, monkeypatch):
"""Simulate a file being deleted after we check for existence but before we try to delete it"""
responses.add( # pylint: disable=no-member
responses.GET, # pylint: disable=no-member
responses.add(
responses.GET,
PUBLIC_SUFFIX_LIST_URLS[0],
status=208,
body="uk.com"
Expand Down
1 change: 0 additions & 1 deletion tldextract/tldextract.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ def _get_tld_extractor(self):
2. Local system _cache file
3. Remote PSL, over HTTP
4. Bundled PSL snapshot file"""
# pylint: disable=no-else-return

if self._extractor:
return self._extractor
Expand Down

0 comments on commit df65b48

Please sign in to comment.