Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Could scheme be made available? #205

Closed
JeffreyShran opened this issue Jul 28, 2020 · 3 comments
Closed

Request: Could scheme be made available? #205

JeffreyShran opened this issue Jul 28, 2020 · 3 comments

Comments

@JeffreyShran
Copy link

Hi,

I'm aware of #6 which asked for some urlparse functionality. This isn't that. It's simply a request to include access to the scheme as part of the standard output.

So instead of:

tldextract.extract('https://blogs.google.com')
# ExtractResult(subdomain='blogs', domain='google', tld='com')

Do this instead:

tldextract.extract('https://blogs.google.com')
# ExtractResult(scheme='https', subdomain='blogs', domain='google', tld='com')
@john-kurkowski
Copy link
Owner

Possible. We're already parsing the scheme. We're considering moving away from namedtuple, to track additional metadata, like in #138. If we make that break, then adding the scheme wouldn't break this library's expected, ordered triple of (subdomain, domain, tld).

@JeffreyShran
Copy link
Author

Thanks @john-kurkowski.

Yes, if you could please keep in the back of your mind that would be great.

@john-kurkowski
Copy link
Owner

#272 (comment)

@john-kurkowski john-kurkowski closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants