-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider network auto-update by default #214
Comments
This sounds useful @brycedrennan - allowing workloads that use Something that occurs to me is that this is a bit like an HTTP caching problem. We have a bundle of content (the TLD metadata) that the application might like to refresh after some time duration has expired. The context may already exist locally (bundled within the package, or in an existing cache), and/or we may want to download an updated version (particularly if the local content has expired). We may want to save the updated copy or it may be discardable. Rather than reimplement HTTP caching, perhaps it'd be worth investigating in-process Python libraries that could take the burden of disk caching off of From that point, it'd be possible to extract flags that enable content updates. If we know that a version of the TLD metadata is bundled in the package (which is fine since it's small), then those could be NB: Hopefully it'd be possible to retain |
Reviving this because its so old. In our case, we run In the context of containers, I'd be happy with setting a |
I ran into this as well. Would a PR adding an environment variable to disable auto-update be welcome? I'd also be happy to add a Github Actions workflow or something to keep the file checked into the repo up to date. |
@brycedrennan, is it possible to have a variation of
if that's possible, we can run a monthly job to repackage the offline variant and push it to pypi. the users can set that up in their side to pull the latest version. |
While it's understandable and useful in many situations to want the latest dataset, it can cause issues in some situations:
Not sure what a solution would look like but here are some ideas:
use_latest
oruse_autoupdating
The text was updated successfully, but these errors were encountered: