Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartyPants not applicable to inline HTML, quotations #361

Open
avery-laird opened this issue Mar 31, 2018 · 0 comments
Open

SmartyPants not applicable to inline HTML, quotations #361

avery-laird opened this issue Mar 31, 2018 · 0 comments

Comments

@avery-laird
Copy link

This is not a major issue, but currently the only way to render a block quote with a citation footer is to inject HTML in the markdown. However, the smartypants extension in redcarpet doesn't touch the HTML, so if something like this is in the markdown:

<blockquote>
  <p>
    "One good test is worth a thousand expert opinions."
  </p>
  <footer><cite title="Wernher Von Braun">Wernher Von Braun</cite></footer>
</blockquote>

Then the quotes will not be converted into HTML entities. Obviously this problem is not limited to blockquotes in particular, but any inlined HTML. Like the original smartypants implementation, nothing inside <pre>, <code>, <kbd>, or <script> tag blocks should be modified, but pretty much anything else should be (as far as I know).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant