Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why lora support is only for simple lora with only q_proj and v_proj ? #155

Open
XpracticeYSKM opened this issue Mar 4, 2024 · 1 comment

Comments

@XpracticeYSKM
Copy link

Thanks for your awesome repo!

I notice that you mentioned "lora support is only for simple lora with only q_proj and v_proj", and I wonder whether I can apply lora with other modules like k_proj、o_proj、donw_proj and so on.

It seems the implementation is not only designed for “q_proj and v_proj“, so why lora support is only for simple lora with only q_proj and v_proj ?

@johnsmith0031
Copy link
Owner

You can add more modules in training scripts if you want add something else like k_proj
"lora support is only for simple lora with only q_proj and v_proj" is about the optimization for inference in this repo, but is already very slow now. It is recommended to use this repo for training and exllamav2 (fastest for now) for inference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants