Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible panes still render children #686

Open
elliotfklein opened this issue Aug 26, 2023 · 1 comment
Open

Invisible panes still render children #686

elliotfklein opened this issue Aug 26, 2023 · 1 comment

Comments

@elliotfklein
Copy link
Contributor

Repro: https://codesandbox.io/s/infallible-wozniak-s6qvcn?file=/src/App.tsx (see that the text is printed in the console)

This is easy to work around (I have a wrapper around allotment that just only includes children if visible), but wanted to confirm that this is expected behavior.

Thanks! 🙂

@OliverWall
Copy link

Hello.

I'm not a developer, but for me personally this is a very convenient behavior. Sometimes you need to expand one panel to the entire screen based on an event, and it would not be very convenient if the state of hidden panels was reset due to the component being unmounted.
Perhaps this behavior should be controlled through an additional prop in the panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants