Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React 19 as a peer dependency #833

Open
argawow opened this issue Dec 18, 2024 · 6 comments
Open

Support for React 19 as a peer dependency #833

argawow opened this issue Dec 18, 2024 · 6 comments

Comments

@argawow
Copy link

argawow commented Dec 18, 2024

Hi there,

Thank you for maintaining this amazing library! I recently upgraded my project to React 19 and noticed that allotment currently has peer dependency constraints for React versions ^17.0.0 || ^18.0.0.

The library appears to work perfectly with React 19 in my tests. Would you consider updating the peerDependencies to include React 19?

Let me know if I can assist with testing or providing more details. Thanks in advance!

Best regards,
Andreas

@criloz
Copy link

criloz commented Dec 18, 2024

I am getting a lot of fatal errors Index out of bounds with react 19 and this library

@argawow
Copy link
Author

argawow commented Dec 19, 2024

Checked it again, everything works fine for me.

@criloz
Copy link

criloz commented Dec 19, 2024

Checked it again, everything works fine for me.

It mostly happens when you rapidly change windows size, and/or have conditional rendering of the panels, I ended using my own solution built with react-aria because my application only have 2 panels anyway

@glebcha
Copy link

glebcha commented Dec 20, 2024

use-resize-observer will require review and/or update https://github.com/ZeeCoder/use-resize-observer/blob/master/package.json#L75

I guess we should track issue of use-resize-observer update to react 19

@DoubleDebug
Copy link

I would also really appreciate it if this library had support for React 19.

@Jun-Murakami
Copy link

I've managed to get it working with the --legacy-peer-deps option, but I think I may have to look for an alternative library.
Does anyone know of any other libraries that they would recommend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants