-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Play/Pause Button #74
Comments
I'd say it's outside the scope of the project. I see it being made up of two parts:
That said, I think it would make a good example/demo. I've got no immediate plans to add any new examples but I will update this issue if I do get around to it. If you wanted to have a go yourself, perhaps as a codepen, I'd be happy to provide assistance. |
I'm wondering except for setting value (slider.value(x)) to make the slider changes, is there any api to tell the slider step into next point according to the setup? (Eg, we have set min, max, and step, now we just call sth to make it forward or backward?) We need API interacts with programmatic controls the slider. |
Hi @geohuz and thanks for the question. You are right in saying that the only way to currently do this is to set the slider value explicitly. I don't have any current plans to add a method to to step to the next (or previous point). However, I'll finally get around to putting together an example of doing this in the next week or so. |
I've started work on an example in this PR #127 |
This is awesome! Can we use it for now? |
Yes, feel free to use the code. I'll also merge the PR this weekend. |
hi @johnwalley would you give me a link for the example code? I could't find it any where, thanks |
https://github.com/johnwalley/d3-simple-slider/pull/168/files Still in the PR for now :) |
Hi @johnwalley thanks for the demo, I've tried to wrap the player into react component, but I found the marker don't move, only the fill progress. Would you mind help me to fix the issue? Here is the link on code sandbox: https://codesandbox.io/s/optimistic-brook-l09pp?file=/src/App.js Thanks |
You could do something like this: https://codesandbox.io/s/angry-river-gldvt. They key is to avoid getting into an infinite loop (user moves handle -> call setPosition -> set value on slider -> call setPosition ->...) which is where slientValue helps. |
@johnwalley appreciate it so much! problem solved! |
I would really like to have an optional play/pause button for the sliders.
Would that be within the scope of your project?
The text was updated successfully, but these errors were encountered: