Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Make jumpurl for dmailerping less error-prone #26

Open
BastianBalthasarBux opened this issue Aug 27, 2020 · 0 comments
Open

Comments

@BastianBalthasarBux
Copy link

BastianBalthasarBux commented Aug 27, 2020

This is really only a nice-to-have:

If the dmailerping.gif (statistics) is included with the domain prefixed, e.g.:
<img src="https://example.example/typo3conf/ext/direct_mail/Resources/Public/Icons/dmailerping.gif" width="1" height="1" dmailerping="1" do_not_embed="1" alt="" border="0" />

You will notice an error in TYPO3 backend (Logging module), because Hook/JumpurlController will throw an exception.

What happens?
The above results in an URL in the mailing like this:
https://example.example/newsletter-test/?mid=6&aC=d0eff497&jumpurl=https://example.example/typo3conf/ext/direct_mail/Resources/Public/Icons/dmailerping.gif

$checkPath then, around line 154, gets something like that:
/path/to/vhosts/example.example/htdocs/https://example.example/typo3conf/ext/direct_mail/Resources/Public/Icons/dmailerping.gif

And this is, obviously, not a valid path, and thus "not allowed" and results in forementioned exception.

Maybe, instead of fixing that code here, it would be better to check for the complete URI when generating the mail content and correcting the URL already at that point.

@BastianBalthasarBux BastianBalthasarBux changed the title [ENHENCEMENT] Make jumpurl for dmailerping less error-prone [ENHANCEMENT] Make jumpurl for dmailerping less error-prone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant