You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I accidentally open it on the wrong library, so here is the link to my issue: rzmn/CropView#10 (comment)
In short - I found solution for this issue, but it includes perform some operations after each time the function configure is called.
I've tried to add the delegate methods by myself (locally) and from some reason they didn't work, the methods aren't getting called.
May you'll be able to add those correctly?
Also, I tried to make those 2 new methods optional ('cause their not must), but couldn't done that.
public protocol DocumentCropViewControllerDelegate: class {
func documentCropViewController(result: Result)
func documentCropViewController(failed: Error)
// New delegate methods
func documentCropViewControllerWillConfigure()
func documentCropViewControllerDidConfigure()
}
public func configure() {
DispatchQueue.main.async { [weak self] in
self?.cropDelegate?.documentCropViewControllerWillConfigure() // Call delegate before configure
}
image = image?.fixOrientation()
imageView.transform = CGAffineTransform.identity
imageView.image = image
imageView.contentMode = .scaleAspectFit
points = defaultCropViewCorners()
guard let image = image else { return }
rectangleDetector.detect(image: image, completion: handleDetection)
DispatchQueue.main.async { [weak self] in
self?.cropDelegate?.documentCropViewControllerDidConfigure() // Call delegate after configure
}
}
Hope you'll be able to add those ASAP,
Ido.
The text was updated successfully, but these errors were encountered:
Idomo
added a commit
to Idomo/SwiftDocumentScanner
that referenced
this issue
Jan 23, 2019
Like I explained in jonasbeckers#9, I was able to make those work after running "Clean Build Folder" from "Product" menu in xCode.
- If you know how - you may want to make those 2 new methods optional, 'cause they're not must.
- If there is need for something like `DispatchQueue.global(qos: .userInitiated).async` that you've included in the other calls for the delegate methods, you may add it (I didn't know if this is related to the cropping itself or to the delegate methods).
Thanks,
Ido.
I accidentally open it on the wrong library, so here is the link to my issue: rzmn/CropView#10 (comment)
In short - I found solution for this issue, but it includes perform some operations after each time the function configure is called.
I've tried to add the delegate methods by myself (locally) and from some reason they didn't work, the methods aren't getting called.
May you'll be able to add those correctly?
Also, I tried to make those 2 new methods optional ('cause their not must), but couldn't done that.
Hope you'll be able to add those ASAP,
Ido.
The text was updated successfully, but these errors were encountered: