Parse response before checking length #16
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the fetch response is not a list but rather a list wrapped in an object, like
then it needs to be parsed before calling
.length
on it to decide whether there are more pages to load. This is exactly what Backbone'sparse
function is used for. The default implementation ofparse
is to just pass the response through, so there's no need to check if it's there before calling it.I don't think what's sent to
success
anderror
should be changed because people probably already depend on it working a certain way. It's less likely that anyone depends onfetchSuccess
's broken behavior instrict: false
mode.This fixes #7.