Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

urlBase and siteId is required even when disabled is true #277

Open
gky360 opened this issue Sep 29, 2020 · 0 comments
Open

urlBase and siteId is required even when disabled is true #277

gky360 opened this issue Sep 29, 2020 · 0 comments

Comments

@gky360
Copy link

gky360 commented Sep 29, 2020

Describe the bug

When creating a MatomoTracker, it raises an error if urlBase or siteId is empty value even when disabled is true.

To Reproduce

Run the following code.

import MatomoTracker from '@datapunt/matomo-tracker-js'

const tracker = new MatomoTracker({
  urlBase: '',
  siteId: 1,
  disabled: true,
})

Expected behavior

We can create MatomoTracker without an error with empty urlBase or siteId when disabled is true.

@gky360 gky360 mentioned this issue Sep 29, 2020
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant