Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Make tracking call to real noop #338

Open
bitPogo opened this issue Oct 29, 2020 · 2 comments
Open

Make tracking call to real noop #338

bitPogo opened this issue Oct 29, 2020 · 2 comments

Comments

@bitPogo
Copy link

bitPogo commented Oct 29, 2020

Describe the bug
In the current implementation, all calls pushes still to window._paq even if the tracker is disabled.

To Reproduce
Steps to reproduce the behavior:

  1. Create a instance of a tracker and set the disabled flag to true
  2. Use pushInstruction() for instance one or multiple times
  3. Inspect the window._paq

Expected behavior
The array should still be empty.

@andyjdavis
Copy link

Is there any value in having window._paq populated when testing Matomo integration into a React app?

@bitPogo
Copy link
Author

bitPogo commented May 26, 2021

Hey, the issue is already a bit aged and I am currently engaged in some other topics, so I just want to let you know that it might can take a short while until I can tell you why I saw there an issue. Hope this is okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants