This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Add getEcommerceItems getter #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying method returns an empty array in that case. The integration should behave indentically.
This is crucial because otherwise window.Matomo is undefined and cannot be used.
This can't be called befire matomo is loaded.
chrisvanmook
reviewed
Aug 3, 2021
| // Return all ecommerce items currently in the untracked ecommerce order. | ||
| // https://matomo.org/docs/ecommerce-analytics | ||
| getEcommerceItems(): EcommerceItems { | ||
| return (this.callMethod('getEcommerceItems') || {}) as EcommerceItems |
There was a problem hiding this comment.
Could we use a generic here instead of casting it? Then it would be this.callMethod<EcommerceItems>
|
Closing this due to inactivity, if this should be reopened please let me know. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing getter.
Since the whole architecture is designed for pushing to matomo (pushInstruction) and not pulling, I've tried to find a way to access all those methods, mentioned in the matomo docs.
My solution is using
window.Matomo.getAsyncTrackers()because an asyncTracker seems to provide all those methods. Not sure if that's the intended/best usage, but it's at least working.I've added a private method
callMethodso it can be reused for other missing getters if someone needs it.Closes #566