Update Mustache render function (.to_html deprecated now). #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexis-renard
changed the title
mhw
added a commit
to mhw/mustache-js-rails
that referenced
this pull request
Jun 11, 2021
Temporary change until jonnyreeves/jquery-Mustache#43 is merged
mhw
added a commit
to mhw/mustache-js-rails
that referenced
this pull request
Jun 11, 2021
Temporary change until jonnyreeves/jquery-Mustache#43 is merged. This updates the submodule dependency and also manually updates the vendored copy of `jquery.mustache.js`: `jquery.mustache.js/src/jquery.mustache.js` has the `.to_html` change but `jquery.mustache.js/jquery.mustache.js` has not been regenerated and so we can't use `rake` to update the vendored assets.
|
See also https://github.com/mhw/jquery-Mustache which builds on Alexis' fix. I've reconciled a divergence between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not functional with the current version of mustache. Please update the README or adapt the code accordingly. :)