Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Error with New Version #116

Open
briankgarland opened this issue Mar 16, 2022 · 9 comments
Open

Build Error with New Version #116

briankgarland opened this issue Mar 16, 2022 · 9 comments

Comments

@briankgarland
Copy link

After the new version released on 3/15/22, I now get the following error. I had to go back to version 1.1.3.

file: D:/a/1/s/node_modules/hamburgers/_sass/hamburgers/_base.scss
line: 60
column: 19
formatted: Error: Invalid CSS after "...argin-top: math": expected expression (e.g. 1px, bold), was ".div($hamburger-lay"
on line 60 of node_modules/hamburgers/_sass/hamburgers/_base.scss
from line 68 of node_modules/hamburgers/_sass/hamburgers/hamburgers.scss

@JamesRobertWiseman
Copy link

@briankgarland I think you might be using 'Live Sass Compiler' extension for VSCode, if so the sass version has more than likely not been updated and is not compatible with this package.

You can use sass globally by running npm install sass -g, and then watch your files by running sass --watch <input-file-path> <output-file-path>. Otherwise there is the extension 'DartJS Sass Compiler' for VSCode which should work, thou I have not tested.

@briankgarland
Copy link
Author

No, this was occurring in our Azure build pipeline. I'll have our DevOps guy look at it from his end. Thanks for the reply.

@nnerijuss
Copy link

Have the same error.

Module build failed: ModuleBuildError: Module build failed:
  margin-top: math.div($hamburger-layer-height, -2);
                 ^
      Invalid CSS after "...argin-top: math": expected expression (e.g. 1px, bold), was ".div($hamburger-lay"

Have been tried all node LTS versions from 10 to 17, error always the same.

@JamesRobertWiseman
Copy link

@nnerijuss Make sure your using the latest version of Dart SASS with your bundler.

@mtx-z
Copy link

mtx-z commented Mar 19, 2022

Note that I had the same issue on my Sage 9.0.9 install which has in it's package.json:

"node-sass": "^4.14.1"

And I added at the time of dev

"hamburgers": "^1.1.3"

Since hamburgers 1.2.1 release, updating dependencies required 1.2.1 and broke the build.

I updated my package.json to require a strict 1.1.3 version "hamburgers": "1.1.3" (removing the ^ ) to correct the issue.

I could also update to Sage 9.0.10 which use "sass": "^1.41.0" instead of node-sass (sass >= 1.33.0 is required for math.div support source 1, 2).

@tatewaky
Copy link

tatewaky commented Apr 1, 2022

@mtx-z thanks for that, totally make sense i even updated it to version 2 and did not worked, your suggestion not only make sense but also finally fix my problem.

@r7l
Copy link

r7l commented Jun 15, 2022

I was running into the same issue using Gulp. I've also tried switching to the latest version of sass instead of node-sass. The error remains. Fixing hamburgers to 1.1.3 seems to be the only option here.

@magicDvlp
Copy link

Same problem. What are the possible solutions?

@magicDvlp
Copy link

Problem solved. I just needed to update sass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants