Added hover color variable and fixed the vertical alignment of the hamburger box #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mburger box I added a new color variable to hamburgers.scss called $hamburger-layer-hover-color to make it easier to change colours on hover. I also added vertical-align: middle; to .hamburger-box so the burger is always centered properly inside .hamburger
|
Hi there @jaclyntan, I've also been looking over this feature. I know you posted the PR some time ago, but you should check the mobile version, it's not working really well (the hover color remains after the button is pressed, which is not the desired solution). I encountered the same issue and I was curious if your solution works, but seems to be the same issue, sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new color variable to hamburgers.scss called
$hamburger-layer-hover-colorto make it easier to change colours on hover.I also added
vertical-align: middle; to .hamburger-box so the burger is always properly centered inside .hamburgerI have used your work on a number of projects and really appreciate your effort on this!! Thank you for your awesome work.