Skip to content

Commit

Permalink
fix: remove 'opts' and update CardCreateOptions (#112)
Browse files Browse the repository at this point in the history
  • Loading branch information
vedrigo authored Jun 16, 2021
1 parent 5059101 commit 8a54840
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 25 deletions.
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ npm install --save-dev pagarme-js-types
...
```

Or if that doesn't work for you, instead of changing the tsconfig.json file,
just create the following file:
```ts
// src/@types/pagarme.d.ts
import 'pagarme-js-types/src/index';
```

See more in the [handbook](http://www.typescriptlang.org/docs/handbook/declaration-files/consumption.html).

## 💪 How to contribute
Expand Down
47 changes: 26 additions & 21 deletions src/client/cards/options.ts
Original file line number Diff line number Diff line change
@@ -1,26 +1,31 @@
export interface CardCreateOptions {
/** Número do cartão. */
card_number: string;
/** Data de expiração do cartão. */
card_expiration_date: string;
/** Nome no cartão do portador. */
card_holder_name: string;
/** Código de segurança do cartão. */
card_cvv?: string;
/** Informações do cliente do card a ser gerado. */
customer_id?: number;
/** Dados criptografados do cartão */
card_hash: string;
}
export type CardCreateOptions = {
/** Informações do cliente do card a ser gerado. */
customer_id?: number;
} & (
| {
/** Número do cartão. */
card_number: string;
/** Data de expiração do cartão. */
card_expiration_date: string;
/** Nome no cartão do portador. */
card_holder_name: string;
/** Código de segurança do cartão. */
card_cvv?: string;
}
| {
/** Dados criptografados do cartão */
card_hash: string;
}
);

export interface CardFindOptions {
/** Id do cartão que deseja consultar os dados. */
id: string;
/** Id do cartão que deseja consultar os dados. */
id: string;
}

export type CardAllOptions = CardFindOptions & {
/** Pagination option to get a list of cards. Number of cards in a page */
count?: number;
/** Pagination option for a list of cards. The page index. */
page?: number;
}
/** Pagination option to get a list of cards. Number of cards in a page */
count?: number;
/** Pagination option for a list of cards. The page index. */
page?: number;
};
1 change: 1 addition & 0 deletions src/client/transactions/namespace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ declare module 'pagarme' {
T extends TransactionFindOptions ? Transaction[] : Transaction
>;

function refund(body: TransactionRefundOptions): Promise<Transaction>;
function refund(
opts: any,
body: TransactionRefundOptions
Expand Down
9 changes: 7 additions & 2 deletions src/client/transfers/namespace.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import { Transfer } from './responses';
import { TransferAllOptions, TransferCreateOptions } from './options';
import {
TransferAllOptions,
TransferCreateOptions,
TransferFindOptions
} from './options';

declare module 'pagarme' {
export namespace client {
Expand All @@ -9,7 +13,8 @@ declare module 'pagarme' {

function cancel(opts: any, body: any): any;
function days(opts: any): any;
function find(opts: any, body: any): any;
function find(body: TransferFindOptions): any;
function find(opts: any, body: TransferFindOptions): any;
function limits(opts: any, params: any): any;
}
}
Expand Down
9 changes: 7 additions & 2 deletions src/client/transfers/options.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export interface TransferCreateOptions {
amount: string;
amount: number;
recipientId: string;
metaData?: JSON;
metaData?: any;
}

export interface TransferAllOptions {
Expand All @@ -14,3 +14,8 @@ export interface TransferAllOptions {
date_created?: string;
created_at?: string;
}


export interface TransferFindOptions {
id?: string;
}

0 comments on commit 8a54840

Please sign in to comment.