Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ID of rules to match Submission Error Codes #79

Open
dryabov opened this issue Jan 31, 2021 · 1 comment
Open

Change ID of rules to match Submission Error Codes #79

dryabov opened this issue Jan 31, 2021 · 1 comment

Comments

@dryabov
Copy link
Collaborator

dryabov commented Jan 31, 2021

I'd suggest to change id of PH3 rule to XM1, and INFO_XML to NM1 to match Submission Error Codes. The only negative effect is that PH3 and INFO_XML are used as a part of keys in language strings. So, either keys should be renamed in all language files, or just allow such a mismatch.
@dryabov
Copy link
Collaborator Author

dryabov commented Feb 3, 2021

Note: with PR#80 the INFO_XML does more than NM1-like check, so let's keep it as as. But changing PH3 to XM1 seems to be reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dryabov