Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploader upload route containing UTF-8 characters #44

Open
amazeika opened this issue Jul 19, 2017 · 6 comments
Open

Uploader upload route containing UTF-8 characters #44

amazeika opened this issue Jul 19, 2017 · 6 comments
Assignees
Milestone

Comments

@amazeika
Copy link
Member

amazeika commented Jul 19, 2017

The uploader options contain the URL as provided by the router route object. If the path contains non encoded characters the json_encode call will encode these if the JSON_UNESCAPED_UNICODE is not set.

See:

@amazeika amazeika added this to the 3.0 milestone Jul 19, 2017
@amazeika
Copy link
Member Author

amazeika commented Sep 4, 2017

@ercanozkaya I've got this support ticket assigned to me. The customer says it got fixed on 3.7.4 but I've just upgraded and still have the same issue.

The problem is when json encoding the URL available in the uploader options. The URL contains the menu item alias and when this one contains special characters these get encoded (not URL encoded) by the json_encode function invalidating the URL.

A solution is to force json_encode not to encode via the JSON_UNESCAPED_UNICODE flag.

Thoughts?

@johanjanssens
Copy link
Member

We have multiple other people reporting similar issues.

@johanjanssens
Copy link
Member

@ercanozkaya @amazeika This one is still hanging, what shall we do with it?

@amazeika
Copy link
Member Author

amazeika commented Feb 9, 2018

@ercanozkaya we haven't yet fixed this have we?

@ercanozkaya
Copy link
Member

ercanozkaya commented Feb 16, 2018 via email

@johanjanssens johanjanssens modified the milestones: 3.0, 3.1 May 4, 2018
@johanjanssens
Copy link
Member

@amazeika @ercanozkaya Is this something we can resolve? Or is it too hard?

@johanjanssens johanjanssens modified the milestones: 3.1, Backlog Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants