New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not compare floats using equality. #16

Open

jordwalke opened this issue Jan 30, 2018 · 0 comments

Owner

jordwalke commented Jan 30, 2018

flex/src/lib/Layout.re

Line 75 in fd0257e

&& cachedLayout.availableHeight == availableHeight

Tradeoff: Any kind of specialized float comparison that uses an epsilon might be slower overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment