Issue with "box-sizing: border-box;"

[artyom-d]

Hi,
I had this kind of an issue when I tried to use the plugin with Bootrap 3.0 and panels. Panel has 1px border on the top and bottom and as Bootrap uses "box-sizing: border-box;" the second panel was always 2px lower because of jQuery.height() function. Maybe you should consider on jQuery.outerHeight() .
Thank you.
P.S. By the way - very nice plugin!

[jorenvanhee]

Hi, Glad you like it :)

Can you make a reduced test case and put it on codepen or jsfiddle?

[artyom-d]

Hi Joren,
Here is the codepen example http://codepen.io/anon/pen/GJpOVe . If you take a look attentively you'll notice that the left column (the one that was changed by the plugin) is 2 px shorter than right one because of the border around the blocks.
Thank you for fast reply.
P.S. I did change your code for my project with $.outerHeight() function and it works good for me, but it is only one case, maybe in other cases it is not good, this needs some investigation.

[artyom-d]

Another suggestion, more like feature request. I really like your responsive feature in the plugin. But there is one thing that you might consider to improve. In Bootstrap Grid there is a situation when at definite width the columns are no longer in one row. In codepen example above I used col-md-5 and col-md-7 grid classes (these are for screens with width more than 992px). When the screen size is reduced to 800px (for example) the columns are no longer in one row and actually there is no need in equal height anymore. It would be nice to have min-width setting in the plugin from which it starts working.

[jorenvanhee]

The example on codepen doesn't seem to work in Chrome, using http://rawgit.com/ to serve your assets should do the job I think.

Then about your suggestion. If you take a look at the advanced example, you can see how I do this. But it would be cool indeed if this was added to the core of the plugin. You can always add a new issue where we can discuss this further.

[artyom-d]

Hi,
Here is a new codepen example http://codepen.io/anon/pen/rVWKEG with rawgit.com service . Thank you for advanced example :) Sorry, I didn't notice it. Nice catch.

[jorenvanhee]

This plugin basically does the same thing but better. I recently used it and it's really nice. So I won't put any more time in my plugin since there's a better one out there. Maybe later, but then a raw js version. Anyway, thanks for your time :)