Ignore return value of unsubscribe handler #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is silently assumed unsubscribe handler has not return value, however if it has it compromises subscriptions processing to make the code more robust I propose to ignore the return value and push into `subs` always `false` (it would work with `unsubscribe` too, but `false` is shorter ;)
|
I was asked to cover this change by tests, but I am not sure how to approach it. #1105 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is silently assumed unsubscribe handler has not return value, however if it has it compromises subscriptions processing. To make the code more robust I propose to ignore the return value and push into
subsalwaysfalse(it would work withundefinedtoo, butfalseis shorter ;)