buttercup --no-skip causes spec text to be printed twice

[snogge]

buttercup --pattern x --no-skip with color causes the spec text to be printed twice, like

Suite text
  spec text   spec text   (2ms)

instead of

Suite text
  spec text   (2ms)

This happens both for passing and failed specs.

[sellout]

I have a similar issue. I’m running buttercup via Eldev, so I’m not exactly sure of the invocation.

The context I’m running in is nix build, color works, but apparently \r doesn’t. I saw #181, and so I’ve also set GITHUB_ACTION=1.

I printed these from my suite to ensure the definitions are as expected, and Eldev or something isn’t modifying the environment.

GITHUB_ACTION: 1
NO_COLOR: nil
buttercup-color: t

It seems like the line below should match and disable batch preprint.

emacs-buttercup/buttercup.el

Line 1820 in bf01a33

(and (getenv "GITHUB_ACTION") buttercup-color)

If that were working, I would suggest maybe replacing the getenv there with a reference to something like (defcustom buttercup-preprint (not (getenv "GITHUB_ACTION"))) … or, even better, if there’s some way to figure this out from the terminfo db (I have no idea). But as it is, it seems like what I have should prevent the double printing, but it’s not.

[snogge]

Can you share the project you are working on and how to trigger the problem?
It would really help me if I can have a step by step instruction starting with cloning the repo.

[sellout]

Sure! The most recent case (and least convoluted instance, probably) is LionyxML/auto-dark-emacs#74.

You can see it happening in CI at https://garnix.io/build/n0l2kX39 (expand the section labeled “checkPhase” just past halfway down).

That PR doesn‘t have GITHUB_ACTION=1 since it wasn’t working, but I put up a branch specifically for replication: https://github.com/sellout/auto-dark-emacs/tree/buttercup-replication

nix build github:sellout/auto-dark-emacs/buttercup-replication -L should replicate it without even needing to clone.

Also, in putting together this branch, I realized that it doesn’t need to be run in a Nix build to see this behavior.

Running it at the command line, I get doubled output (colored, which doesn’t translate to GFM)

$ GITHUB_ACTION=1 eldev test --test-type=main
Buttercup version: buttercup-1.36
GITHUB_ACTION: 1
NO_COLOR: nil
TERM: xterm-16color
buttercup-color: t
Running 6 specs.

when disabled
  shouldn’t affect enabled themes  shouldn’t affect enabled themes (2.16ms)
…

And in a Nix build (also colored)

$ nix build -L
…
emacs-auto-dark> Buttercup version: buttercup-20240328.2016
emacs-auto-dark> GITHUB_ACTION: 1
emacs-auto-dark> NO_COLOR: nil
emacs-auto-dark> TERM: xterm-256color
emacs-auto-dark> buttercup-color: t
emacs-auto-dark> Running 6 specs.
emacs-auto-dark> when disabled
emacs-auto-dark>   shouldn’t affect enabled themes  shouldn’t affect enabled themes (2.22ms)
…

I get different Buttercup versions (newer outside of Nix), but both have the GITHUB_ACTION line in them. Also I do run other software in the same terminal/shell that uses \r to clear lines and succeeds.