node-ethereum / vapor compatibility

[jorisbontje]

• missing RPC method eth_accounts
• missing RPC method eth_coinbase
• missing RPC method eth_defaultBlock
• missing RPC method eth_logs
• missing RPC method eth_mining
• RPC method eth_codeAt returning Buffer instead of hexstring
• RPC method eth_balanceAt returning empty string for 0 balance instead of 0x.
• RPC method eth_blockByNumber throws 500.
• RPC method eth_listening throws 500. RPC eth_listening throws error ethereum/node-ethereum#52
• RPC method eth_number not returning any result.
• RPC methods returning hex strings lack 0x prefix
• RPC errors throw 500 instead of returning Error object. xhrrpc does not return error ethereum/node-ethereum#49
• vapor requires all dapp assets to exist in a single html file

[wanderer]

whoa nice i love checklists!

[wanderer]

also note https://github.com/ethereum/wiki/wiki/JSON-RPC-Improvement-Proposal

[wanderer]

@kumavis is eth_accounts in vapor?

[wanderer]

listing should be fixed ethereum/node-ethereum#52

[kumavis]

eth_accounts and eth_coinbase are covered in vapor. Correct behavior of the coinbase op code for the vapor backing server is not clear yet. I would imagine we'd tell the vm to use the sender's address as the coinbase whenever they send a transact or call

[wanderer]

oh the coinbase opcode is well defined. it just gives back the coinbase of the block that mined the tx. for eth_accounts i just stubed it out and it will just return [] incase someone tries to use it

[wanderer]

eth_codeAt should be fixed now

[wanderer]

for eth_balanceAt returning 0x is silly. is that really nessicary?

[kumavis]

Correct behavior of the coinbase op code for the vapor backing server is not clear yet.

I don't mean in general. Like what do dapp builders expect the opcode to mean? Dapps should not care about mining at all, so they much be using it as a proxy for something else. primary identity of user of the dapp? yeah probably.
Edit: kinda confused eth.coinbase and coinbase op code there. why is it an opcode? whats the usecase?

[wanderer]

ok blockbynumber is returning blocks now

[wanderer]

@kumavis coinbase is sort of controversial opcode. but one use is using like a PRNG

[wanderer]

ok eth_number is returning a number

[kumavis]

@wanderer hmmm weird. Maybe offer a PRNG opcode that is derived from the coinbase? weird. kinda sticky situation.

[jorisbontje]

@kumavis @wanderer I don't really need coinbase actually, but I have it on my command line testing tools to verify if mining is working and which of my node(s) is doing the mining.

[wanderer]

ok working on methods returning hex strings lack 0x prefix

[kumavis]

"vapor requires all dapp assets to exist in a single html file" is of course a vapor bug -- but I anticipate putting this off for awhile to see how dapp-requesting settles

Here is the current doc on the subject, clearly in flux
https://github.com/ethereum/wiki/wiki/URL-Hint-Protocol

[kumavis]

I've used this before to inline external assets into a single html file https://github.com/substack/html-inline