Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions #1

Open
wcampbell0x2a opened this issue Apr 25, 2021 · 0 comments
Open

Questions #1

wcampbell0x2a opened this issue Apr 25, 2021 · 0 comments

Comments

@wcampbell0x2a
Copy link

Hey, sweet idea and project. A couple of questions I have about the project.

unix

For one, I am using a unix machine, and I needed the following patch in order for this to work:

diff --git a/foo_dissector/build.rs b/foo_dissector/build.rs
index 7fb5b7b..be633e2 100644
--- a/foo_dissector/build.rs
+++ b/foo_dissector/build.rs
@@ -1,4 +1,4 @@
 fn main() {
-    println!("cargo:rustc-link-lib=wireshark-src/build/libwireshark");
+    println!("cargo:rustc-link-lib=wireshark");
     println!("cargo:rerun-if-changed=src/wireshark.h");
 }

This allowed libwireshark to work without the wireshark source, and use the installed wireshark includes. Pretty neat.

wireshark 3.4.4

I was trying to weed through your documentation and code while trying to update this to a recent version of wireshark. I understand I would need to regenerate the bindings.rs file. I am not sure if I am supposed to use the vscode instructions or the libwireshark_scripts program. The libwireshark_scripts doesn't work, and I assume the wireshark-sys directory is the wireshark source(which is required?, might need to be a submodule if it always needs the wireshark source)?

build.rs

I think the common way of generating the bindings is using a build.rs for _sys libraries, I think that would be better for generating the bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant