-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posts overflow under cover panel #42
Comments
Yes noticed the same issue on desktop and mobile as well. |
I haven't test it. But try this: Add the following code to line 6 and line 20 and line 25 at main.js as a new code lines And the following code to line 1106 at uno.css Your problem must be solved. Short speech;
|
Yup, @tayfuncetin your fix works. Thanks :) |
Cool runnings so far. Thanks very much! |
@tayfuncetin can you make a quick PR for this fix? |
@blackbaud-joshgerdes I'm not familiar with how Github works. So can you make this PR for me? |
Implementing the fix from @tayfuncetin, referenced here: joshgerdes#42 (comment)
Implementing the fix from @tayfuncetin, referenced here: joshgerdes#42 (comment)
This does fix the issue for me, however, doing so when i click on "older posts" nothing renders on the page. only the first page shows posts. if i revmove the two lines, then they are back, but i have the scrolling issue. you can see it on my site. https://grposh.github.io. any suggestions? |
nvm, i fixed it, here is my js file, notice mine is the
|
Implementing the fix from @tayfuncetin, referenced here: joshgerdes/jekyll-uno#42 (comment) Still require one more css fix.
Implementing the fix from @tayfuncetin, referenced here: joshgerdes/jekyll-uno#42 (comment)
Implementing the fix from @tayfuncetin, referenced here: joshgerdes/jekyll-uno#42 (comment) Adapting the original Jekyll fix to the Hugo version of the theme.
So I'm not sure how to phrase this, but I've noticed that with a sufficient number of posts listed by paginate (such as on your own homepage), one is able to scroll on the uncollapsed cover-page. A scrollbar is visible and even operational since the position carries over when the blog link is clicked and collapses the cover. That's kind of irritating, since I think it would be most new visitors' first inclination to scroll down before clicking that link. On mobile (chrome for android, in my case), it is possible to view the scrolling content below the cover image with a little fiddling around (desktop just shows white above and below the image when attempting to scroll past).
Maybe it's not possible to fix without taking paginate out of the main index.html (I'll probably try this), or maybe the overflow CSS property would do the trick (I couldn't figure out where to implement it if that is the case, however), but I think it really detracts from an otherwise clean and beautiful theme.
Or maybe a different version of paginate with more flexibility would work?
The text was updated successfully, but these errors were encountered: