add styling for login form component #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 20, 2020
jitendrasbunde
force-pushed
the
feature/react/138/add-styling-to-login-form-components
branch
from
df5879b
to
194beeb
Compare
mayuriardad
suggested changes
May 24, 2020
| import LoginTextComponent from "shared-components/login-text-component/LoginTextComponent"; | ||
|
|
||
| const Wrapper = Styled.div` | ||
| background: #334856; |
There was a problem hiding this comment.
indentation fix
cc @sahilbhatia
| @@ -0,0 +1,15 @@ | |||
| import React from "react"; | |||
| import { render } from "@testing-library/react"; | |||
| import LoginTextComponent from "./LoginTextComponent"; | |||
There was a problem hiding this comment.
absolute import missing
react-frontend/src/shared-components/login-text-component/LoginTextComponent.js
Outdated
Show resolved
Hide resolved
react-frontend/src/shared-components/peerly-logo/LogoComponent.js
Outdated
Show resolved
Hide resolved
jitendrasbunde
force-pushed
the
feature/react/138/add-styling-to-login-form-components
branch
2 times, most recently
from
b34e409
to
557d200
Compare
jitendrasbunde
removed
the
Changes Requested
mayuriardad
suggested changes
May 25, 2020
| `; | ||
| const PlusSign = Styled.div` | ||
| position: absolute; | ||
| top: 55%; |
There was a problem hiding this comment.
indentation fix, when we add a single comment, always check if the same mistake is repeated elsewhere
jitendrasbunde
removed
the
Changes Requested
jitendrasbunde
force-pushed
the
feature/react/138/add-styling-to-login-form-components
branch
from
8bd8f30
to
6f3d2b4
Compare
mayuriardad
suggested changes
May 27, 2020
jitendrasbunde
force-pushed
the
feature/react/138/add-styling-to-login-form-components
branch
from
69e5454
to
b96887b
Compare
…and remove row and col structure
jitendrasbunde
removed
the
Changes Requested
mayuriardad
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is depend on below PR's unless until below PR's are not merge. This PR are not merge
#144
#145
In GoogleLoginButton component clientId and cookiePolicy props are pass by env variable if you not pass by env it will give error at inspect console