Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a container for Api integration for recognition listing #167

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

create a container for Api integration for recognition listing #167

wants to merge 35 commits into from

Conversation

jitendrasbunde
Copy link
Contributor

@jitendrasbunde jitendrasbunde commented May 26, 2020 •
edited
Loading

This container is depend upon login container. #153
This container is depend upon List Recognition Presentational Component. #163
I have added saga for API integration.
Managed state using reducer.
create a mock response file's for test.
add test cases for saga API integration
add test cases for reducer.

@jitendrasbunde jitendrasbunde added enhancement New feature or request react-frontend For PRs of peerly react app labels May 26, 2020
@jitendrasbunde jitendrasbunde self-assigned this May 26, 2020
@jitendrasbunde jitendrasbunde force-pushed the feature/react/165/create-a-container-for-api-integration-for-recognition-listing branch 4 times, most recently from 5bd60fd to 11f2613 Compare May 26, 2020 14:34
This was linked to issues May 26, 2020
Create a container for API integration for recognition listing #165
Open
write test cases for recognition listing container and recognition saga #169
Open
@jitendrasbunde jitendrasbunde marked this pull request as ready for review May 29, 2020 08:34
@jitendrasbunde
create reducer for store recognition list
4b4be35
@jitendrasbunde
update recognition Reducer
1ee0089
@jitendrasbunde
add recognitionReducer in root combineReducers
5464f6e
@jitendrasbunde
create recognitionSaga file for run sagaMiddleware for Api call
709c5df
@jitendrasbunde
add code in redux-store for run recognitionSaga at sagaMiddleware
8bc9d70
@jitendrasbunde
add RecognitionListContainer and add store.dispatch code for saga Api…
b23825f 
… call
@jitendrasbunde
change the position to use of recognitionSaga middleware
41e4847
@jitendrasbunde
add some error related rendering code
e86e4d1
@jitendrasbunde
restructure default state of recognition reducer
3cf2b24
@jitendrasbunde
adjust code as per default state of recognition reducer
ede91cd
@jitendrasbunde
add SessionTimeoutComponent and UnauthorisedErrorComponent for render…
da84186 
…ing on error
@jitendrasbunde
add test case file for recognitionReducer
6910d53
@jitendrasbunde
add one test case in recognitionReducer.test.js file action at failure
1a840db
@jitendrasbunde
add test case file for recognitionSaga middleware
2e30634
@jitendrasbunde
rename and recogntionReducer file name and use actionGenerator utils …
b4cc2c0 
…function on it
@jitendrasbunde jitendrasbunde force-pushed the feature/react/165/create-a-container-for-api-integration-for-recognition-listing branch from 88d9675 to 7e1bcf4 Compare June 10, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayuriardad mayuriardad Awaiting requested review from mayuriardad

Assignees

@jitendrasbunde jitendrasbunde

@mayuriardad mayuriardad

Labels
enhancement New feature or request react-frontend For PRs of peerly react app
Projects
None yet
Milestone
No milestone
2 participants
@jitendrasbunde @mayuriardad