-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index block information #5
Comments
Hello. Talking about saving space in the database, what about using |
The main reason char(42) works quite nice as the db protects against bad mistakes from the code say the address got messed up somehow, it would throw on the DB level and not just let it happen, which can make you see some of these issues before they become impossible to find - sometimes they may have more benefit then space.. opening to talk about bytea if we feel the size benefit is dramatically better cc @MattKetmo |
@joshstevens19 what kind of protection does it really provide?
I'm curious what you have in mind in term of protection. |
you are probably right tbh char(42) it just pad it if its to short or shorten it its to long which has the same kind of issue (does not protect anymore), so yeah bytea sounds like it has the same benefit but smaller size so I'm up to change it feel free to create an issue for it and il look at it thanks for the suggestion |
it be nice to be able to index the block information once and then join from the block number to those tables meaning you do not repeat block hash and timestamp all the time. This task is to write the block information in the database as well and remove the repeating fields it does when it indexes an event each time, this will save space in the database.
The text was updated successfully, but these errors were encountered: