Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] make the notification queue-able? #8

Open
Yahav opened this issue Jan 27, 2018 · 3 comments
Open

[enhancement] make the notification queue-able? #8

Yahav opened this issue Jan 27, 2018 · 3 comments

Comments

@Yahav
Copy link
Contributor

Yahav commented Jan 27, 2018

Hey now,
Perhaps making the verification email notification queue-able is a good idea?

@josiasmontag
Copy link
Owner

Not sure if this is a reasonable default behaviour for this package. Queued notifications would break the translations: laravel/ideas#394.

If you don't need translated mails, you can easily override the notification and add ShouldQueue.

@Yahav
Copy link
Contributor Author

Yahav commented Jan 29, 2018

They won’t break it if you pass the session language within..perhaps make a config attr to activate this behavior, anyway it should be fairly easy and would make this package more compatible with large projects.

@Yahav Yahav changed the title make the notification queue-able? [enhancement] make the notification queue-able? Jan 30, 2018
@AEK-BKF
Copy link

AEK-BKF commented Mar 31, 2018

Any news about this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants