rpc/generatetoaddress: Reject Silent Payment addresses

josibake · Oct 1, 2024 · 115d59c · 115d59c
1 parent 6f442fa
commit 115d59c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp
@@ -43,6 +43,7 @@
 
 #include <memory>
 #include <stdint.h>
+#include <variant>
 
 using node::BlockAssembler;
 using node::CBlockTemplate;
@@ -285,6 +286,9 @@ static RPCHelpMan generatetoaddress()
     if (!IsValidDestination(destination)) {
         throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Error: Invalid address");
     }
+    if (std::get_if<V0SilentPaymentDestination>(&destination)) {
+        throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Error: Cannot pay to Silent Payment Output in Coinbase transactions");
+    }
 
     NodeContext& node = EnsureAnyNodeContext(request.context);
     Mining& miner = EnsureMining(node);